Fix bug that caused screenview to stay off when screenshare was toggled #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylonChime
force-pushed
the
fix-screenshare-stopping-screenview-bug
branch
from
fedfe4d to
c85d5ab
Compare
aws-geoff
previously approved these changes
Dec 10, 2019
andi-amzn
suggested changes
Dec 10, 2019
| @@ -188,6 +188,18 @@ export default class DefaultScreenViewingDeltaRenderer implements ScreenViewingD | |||
| } | |||
| } | |||
|
|
|||
| hideViewport(): void { | |||
| if (this.viewport) { | |||
| this.viewport.style.display = 'none'; | |||
There was a problem hiding this comment.
I don't think we should modify the CSS styling of the viewport since this is an element that is passed in by the SDK consumer. In particular, they may be controlling the display attribute themselves and so this could overwrite the attribute. Is there some other way to accomplish the objective here without using CSS styling?
There was a problem hiding this comment.
As discussed offline, I modified the CSS for the canvas element rather than the exposed viewport.
dylonChime
force-pushed
the
fix-screenshare-stopping-screenview-bug
branch
3 times, most recently
from
b71418d to
339a3f0
Compare
andi-amzn
reviewed
Dec 11, 2019
| @@ -188,6 +188,18 @@ export default class DefaultScreenViewingDeltaRenderer implements ScreenViewingD | |||
| } | |||
| } | |||
|
|
|||
| hideViewport(): void { | |||
| if (this.viewport) { | |||
| } | ||
|
|
||
| revealViewport(): void { | ||
| if (this.viewport) { |
dylonChime
force-pushed
the
fix-screenshare-stopping-screenview-bug
branch
from
339a3f0 to
75d708f
Compare
andi-amzn
reviewed
Dec 11, 2019
| @@ -434,4 +434,21 @@ describe('DefaultScreenViewingDeltaRenderer', () => { | |||
| deltaRenderer.zoomReset(); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('hideViewport and revealViewport', () => { | |||
| it('hides and reveals the viewport', () => { | |||
There was a problem hiding this comment.
This test does not verify the change made by hideViewport or revealViewport. It looks like other tests in this file check properties of the canvas. Could we do the same here?
dylonChime
force-pushed
the
fix-screenshare-stopping-screenview-bug
branch
from
75d708f to
2d87e3c
Compare
andi-amzn
approved these changes
Dec 16, 2019
michhyun1
pushed a commit
that referenced
this pull request
Jul 7, 2021
* Create Chat Application Demo This is taken from https://github.com/aws/amazon-chime-sdk-component-library-react/tree/master/demo/chat which will be deprecated on move. It adds support for authentication via STS lambda. * README has directions for new demo location * Minor README typo fixes Co-authored-by: David Witherspoon <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
#6
Description of changes
Added hide and reveal methods to deltaRenderer. This allows screen view to stay open but hidden when screen share closes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.